diff options
| author | Anson Huang <Anson.Huang@nxp.com> | 2020-03-20 07:44:03 +0800 | 
|---|---|---|
| committer | Shawn Guo <shawnguo@kernel.org> | 2020-04-20 22:56:35 +0800 | 
| commit | 9558b51ab739920aaf3c400d2df29e5ca4f19ec5 (patch) | |
| tree | d0bedeaa34c47297e9778da8446fb58dd5eb4b73 | |
| parent | 23aadcb9a8d59cd12fbf2cbe9be8479429bf0dae (diff) | |
clk: imx: clk-pllv3: Use readl_relaxed_poll_timeout() for PLL lock wait
Use readl_relaxed_poll_timeout() for PLL lock wait which can simplify the
code a lot.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
| -rw-r--r-- | drivers/clk/imx/clk-pllv3.c | 16 | 
1 files changed, 5 insertions, 11 deletions
| diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index df91a8244fb4..a7db93030e02 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -7,6 +7,7 @@  #include <linux/clk-provider.h>  #include <linux/delay.h>  #include <linux/io.h> +#include <linux/iopoll.h>  #include <linux/slab.h>  #include <linux/jiffies.h>  #include <linux/err.h> @@ -25,6 +26,8 @@  #define IMX7_ENET_PLL_POWER	(0x1 << 5)  #define IMX7_DDR_PLL_POWER	(0x1 << 20) +#define PLL_LOCK_TIMEOUT	10000 +  /**   * struct clk_pllv3 - IMX PLL clock version 3   * @clk_hw:	 clock source @@ -53,23 +56,14 @@ struct clk_pllv3 {  static int clk_pllv3_wait_lock(struct clk_pllv3 *pll)  { -	unsigned long timeout = jiffies + msecs_to_jiffies(10);  	u32 val = readl_relaxed(pll->base) & pll->power_bit;  	/* No need to wait for lock when pll is not powered up */  	if ((pll->powerup_set && !val) || (!pll->powerup_set && val))  		return 0; -	/* Wait for PLL to lock */ -	do { -		if (readl_relaxed(pll->base) & BM_PLL_LOCK) -			break; -		if (time_after(jiffies, timeout)) -			break; -		usleep_range(50, 500); -	} while (1); - -	return readl_relaxed(pll->base) & BM_PLL_LOCK ? 0 : -ETIMEDOUT; +	return readl_relaxed_poll_timeout(pll->base, val, val & BM_PLL_LOCK, +					  500, PLL_LOCK_TIMEOUT);  }  static int clk_pllv3_prepare(struct clk_hw *hw) | 
