diff options
| author | Christian König <christian.koenig@amd.com> | 2024-09-05 15:51:54 +0200 |
|---|---|---|
| committer | Christian König <christian.koenig@amd.com> | 2024-10-09 14:22:49 +0200 |
| commit | 967d226eaae8e40636d257bf8ae55d2c5a912f58 (patch) | |
| tree | 000ae61fd4bcff2c320f6a2800007e313390c642 | |
| parent | 4cce1373c17fc527b78ad22ddca3027042aea3a0 (diff) | |
dma-buf: add WARN_ON() illegal dma-fence signaling
Calling the signaling a NULL fence is obviously a coding error in a
driver. Those functions unfortunately just returned silently without
raising a warning.
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20240911085903.1496-2-christian.koenig@amd.com
| -rw-r--r-- | drivers/dma-buf/dma-fence.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index f8303ae99acf..f0cdd3e99d36 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers/dma-buf/dma-fence.c @@ -412,7 +412,7 @@ int dma_fence_signal_timestamp(struct dma_fence *fence, ktime_t timestamp) unsigned long flags; int ret; - if (!fence) + if (WARN_ON(!fence)) return -EINVAL; spin_lock_irqsave(fence->lock, flags); @@ -464,7 +464,7 @@ int dma_fence_signal(struct dma_fence *fence) int ret; bool tmp; - if (!fence) + if (WARN_ON(!fence)) return -EINVAL; tmp = dma_fence_begin_signalling(); |