diff options
| author | Danila Chernetsov <listdansp@mail.ru> | 2025-03-19 01:30:11 +0000 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2025-03-26 22:39:21 +0100 |
| commit | aee50bd88ea5fde1ff4cc021385598f81a65830c (patch) | |
| tree | d4cacfff89d0fa98e8463ab2b8cdb0bff0fca2b3 | |
| parent | 3e411827f31db7f938a30a3c7a7599839401ec30 (diff) | |
fbdev: sm501fb: Add some geometry checks.
Added checks for xoffset, yoffset settings.
Incorrect settings of these parameters can lead to errors
in sm501fb_pan_ functions.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 5fc404e47bdf ("[PATCH] fb: SM501 framebuffer driver")
Signed-off-by: Danila Chernetsov <listdansp@mail.ru>
Signed-off-by: Helge Deller <deller@gmx.de>
| -rw-r--r-- | drivers/video/fbdev/sm501fb.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index 7734377b2d87..ed6f4f43e2d5 100644 --- a/drivers/video/fbdev/sm501fb.c +++ b/drivers/video/fbdev/sm501fb.c @@ -327,6 +327,13 @@ static int sm501fb_check_var(struct fb_var_screeninfo *var, if (var->xres_virtual > 4096 || var->yres_virtual > 2048) return -EINVAL; + /* geometry sanity checks */ + if (var->xres + var->xoffset > var->xres_virtual) + return -EINVAL; + + if (var->yres + var->yoffset > var->yres_virtual) + return -EINVAL; + /* can cope with 8,16 or 32bpp */ if (var->bits_per_pixel <= 8) |