diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2025-10-10 21:04:16 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-10-13 08:26:22 -0500 |
| commit | b9ce79887e270ed64ed499aa69f903cdca401c2f (patch) | |
| tree | 989a02fd0d833bfa5e92c3c385ca039780992413 | |
| parent | 3a8660878839faadb4f1a6dd72c3179c1df56787 (diff) | |
smb: client: Return a status code only as a constant in sid_to_id()
Return a status code without storing it in an intermediate variable.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/cifsacl.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/smb/client/cifsacl.c b/fs/smb/client/cifsacl.c index 63b3b1290bed..ce2ebc213a1d 100644 --- a/fs/smb/client/cifsacl.c +++ b/fs/smb/client/cifsacl.c @@ -339,7 +339,6 @@ int sid_to_id(struct cifs_sb_info *cifs_sb, struct smb_sid *psid, struct cifs_fattr *fattr, uint sidtype) { - int rc = 0; struct key *sidkey; char *sidstr; const struct cred *saved_cred; @@ -446,12 +445,12 @@ out_revert_creds: * fails then we just fall back to using the ctx->linux_uid/linux_gid. */ got_valid_id: - rc = 0; if (sidtype == SIDOWNER) fattr->cf_uid = fuid; else fattr->cf_gid = fgid; - return rc; + + return 0; } int |