summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>2025-09-08 17:41:57 +0200
committerAndrew Morton <akpm@linux-foundation.org>2025-09-21 14:22:27 -0700
commitd322f6a24ee5964a58294f61bf96a1b6404c676d (patch)
treefdd68c058af3a6935825dff01d6e2b838b1da553
parent90ec2df9dd31653ceac4a35d2440b108bdf27550 (diff)
scripts/decode_stacktrace.sh: symbol: avoid trailing whitespaces
A few patches slightly improving the output generated by decode_stacktrace.sh. This patch (of 3): Lines having a symbol to decode might not always have info after this symbol. It means ${info_str} might not be set, but it will always be printed after a space, causing trailing whitespaces. That's a detail, but when the output is opened with an editor marking these trailing whitespaces, that's a bit disturbing. It is easy to remove them by printing this variable with a space only if it is set. While at it, do the same with ${module} and print everything in one line. Link: https://lkml.kernel.org/r/20250908-decode_strace_indent-v1-0-28e5e4758080@kernel.org Link: https://lkml.kernel.org/r/20250908-decode_strace_indent-v1-1-28e5e4758080@kernel.org Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Reviewed-by: Carlos Llamas <cmllamas@google.com> Reviewed-by: Breno Leitao <leitao@debian.org> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Cc: Carlos Llamas <cmllamas@google.com> Cc: Elliot Berman <quic_eberman@quicinc.com> Cc: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rwxr-xr-xscripts/decode_stacktrace.sh7
1 files changed, 1 insertions, 6 deletions
diff --git a/scripts/decode_stacktrace.sh b/scripts/decode_stacktrace.sh
index 17abc4e7a985..c6b5c14412f0 100755
--- a/scripts/decode_stacktrace.sh
+++ b/scripts/decode_stacktrace.sh
@@ -323,12 +323,7 @@ handle_line() {
parse_symbol # modifies $symbol
# Add up the line number to the symbol
- if [[ -z ${module} ]]
- then
- echo "${words[@]}" "$symbol ${info_str}"
- else
- echo "${words[@]}" "$symbol $module ${info_str}"
- fi
+ echo "${words[@]}" "${symbol}${module:+ ${module}}${info_str:+ ${info_str}}"
}
while read line; do