diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2025-11-05 17:02:44 +0800 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2025-11-21 10:20:51 -0800 |
| commit | ef1b6d904993d3a21baa7d4105e1a4e4ba9dd6de (patch) | |
| tree | 72e8b100b2b619c7e405f91238296ac133862dbc /drivers | |
| parent | 5f40ea7f41773d996d92db8bde600199200adc11 (diff) | |
EDAC/igen6: Fix error handling in igen6_edac driver
The igen6_edac driver calls device_initialize() for all memory
controllers in igen6_register_mci(), but misses corresponding
put_device() calls in error paths and during normal shutdown in
igen6_unregister_mcis().
Adding the missing put_device() calls improves code readability and
ensures proper reference counting for the device structure.
Found by code review.
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://patch.msgid.link/20251105090244.23327-1-make24@iscas.ac.cn
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/edac/igen6_edac.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c index 2fc59f9eed69..553c31a2d922 100644 --- a/drivers/edac/igen6_edac.c +++ b/drivers/edac/igen6_edac.c @@ -1300,6 +1300,7 @@ static int igen6_register_mci(int mc, void __iomem *window, struct pci_dev *pdev imc->mci = mci; return 0; fail3: + put_device(&imc->dev); mci->pvt_info = NULL; kfree(mci->ctl_name); fail2: @@ -1326,6 +1327,7 @@ static void igen6_unregister_mcis(void) kfree(mci->ctl_name); mci->pvt_info = NULL; edac_mc_free(mci); + put_device(&imc->dev); iounmap(imc->window); } } |