diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2025-04-30 11:18:28 +0900 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-05-01 18:58:48 -0500 |
| commit | 53e3e5babc0963a92d856a5ec0ce92c59f54bc12 (patch) | |
| tree | d592500513683fd0d9ea2788e9d080418f3e49b8 /fs | |
| parent | ca91b9500108d4cf083a635c2e11c884d5dd20ea (diff) | |
ksmbd: prevent rename with empty string
Client can send empty newname string to ksmbd server.
It will cause a kernel oops from d_alloc.
This patch return the error when attempting to rename
a file or directory with an empty new name string.
Cc: stable@vger.kernel.org
Reported-by: Norbert Szetei <norbert@doyensec.com>
Tested-by: Norbert Szetei <norbert@doyensec.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/smb/server/smb2pdu.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 46aa08245742..f2a2be8467c6 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -633,6 +633,11 @@ smb2_get_name(const char *src, const int maxlen, struct nls_table *local_nls) return name; } + if (*name == '\0') { + kfree(name); + return ERR_PTR(-EINVAL); + } + if (*name == '\\') { pr_err("not allow directory name included leading slash\n"); kfree(name); |