diff options
| author | Tingmao Wang <m@maowtm.org> | 2025-11-02 23:56:30 +0000 |
|---|---|---|
| committer | Dominique Martinet <asmadeus@codewreck.org> | 2025-11-03 16:49:53 +0900 |
| commit | a63dd8fd137933551bfd9aeeeaa942f04c7aad65 (patch) | |
| tree | 55cded8d58d36deb7767af09d0fbc0a7bcb6340b /include/linux/fs_parser.h | |
| parent | eeaf38a798aff6384983e5a0ac464d146de7ff55 (diff) | |
fs/9p: Don't open remote file with APPEND mode when writeback cache is used
When page cache is used, writebacks are done on a page granularity, and it
is expected that the underlying filesystem (such as v9fs) should respect
the write position. However, currently v9fs will passthrough O_APPEND to
the server even on cached mode. This causes data corruption if a sync or
fstat gets between two writes to the same file.
This patch removes the APPEND flag from the open request we send to the
server when writeback caching is involved. I believe keeping server-side
APPEND is probably fine for uncached mode (even if two fds are opened, one
without O_APPEND and one with it, this should still be fine since they
would use separate fid for the writes).
Signed-off-by: Tingmao Wang <m@maowtm.org>
Fixes: 4eb3117888a9 ("fs/9p: Rework cache modes and add new options to Documentation")
Message-ID: <20251102235631.8724-1-m@maowtm.org>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Diffstat (limited to 'include/linux/fs_parser.h')
0 files changed, 0 insertions, 0 deletions
