diff options
| author | Pavel Begunkov <asml.silence@gmail.com> | 2025-02-19 10:09:54 +0000 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2025-02-19 14:52:58 -0700 |
| commit | 95e65f2d0bdef883b09b7044b1435a36819ae38a (patch) | |
| tree | 80da393567a7876fc74fd3519d3d0955657ca996 /io_uring/zcrx.c | |
| parent | bc674a04c47cc23ad7e12893cad6226ea8f7a8ec (diff) | |
io_uring/zcrx: fix leaks on failed registration
If we try to register a device-less interface like veth,
io_register_zcrx_ifq() will leak struct io_zcrx_ifq with a bunch of
resources attached to it. Fix that.
Fixes: 035af94b39fd ("io_uring/zcrx: grab a net device")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202502190532.W7NnmyiP-lkp@intel.com/
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/fbf16279dd73fa4c6df048168728355636ba5f53.1739959771.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring/zcrx.c')
| -rw-r--r-- | io_uring/zcrx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index a9eaab3fccf2..f2d326e18e67 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -388,8 +388,9 @@ int io_register_zcrx_ifq(struct io_ring_ctx *ctx, goto err; ifq->dev = ifq->netdev->dev.parent; + ret = -EOPNOTSUPP; if (!ifq->dev) - return -EOPNOTSUPP; + goto err; get_device(ifq->dev); ret = io_zcrx_map_area(ifq, ifq->area); |