diff options
| author | David Daney <david.daney@cavium.com> | 2013-02-26 14:35:23 -0800 | 
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2013-03-12 18:57:47 +0100 | 
| commit | 0c81157b46c533139d6be721d41617020c59a2c3 (patch) | |
| tree | dfc722ef55660acb1b963f68cee57eb1404d5cfa /lib/mpi/mpi-bit.c | |
| parent | e744109fce4b9581acdc23287667e240bcd239b7 (diff) | |
MIPS: Fix logic errors in bitops.c
commit 92d11594f6 (MIPS: Remove irqflags.h dependency from bitops.h)
factored some of the bitops code out into a separate file
(arch/mips/lib/bitops.c).  Unfortunately the logic converting a bit
mask into a boolean result was lost in some of the functions.  We had:
   int res;
   unsigned long shifted_result_bit;
   .
   .
   .
   res = shifted_result_bit;
   return res;
Which truncates off the high 32 bits (thus yielding an incorrect
value) on 64-bit systems.
The manifestation of this is that a non-SMP 64-bit kernel will not
boot as the bitmap operations in bootmem.c are all screwed up.
Signed-off-by: David Daney <david.daney@cavium.com>
Cc:  linux-mips@linux-mips.org
Cc: Jim Quinlan <jim2101024@gmail.com>
Cc: stable@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/4965/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'lib/mpi/mpi-bit.c')
0 files changed, 0 insertions, 0 deletions
