diff options
| author | Jon Hunter <jonathanh@nvidia.com> | 2019-05-24 09:54:04 +0100 | 
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-05-24 13:10:33 +0100 | 
| commit | 4819d06292c9b57eabdd6d1603e49a27baf183be (patch) | |
| tree | 7b3e4dc42fbfb102018806bb5aaea4b83962a26e /lib/mpi/mpi-internal.h | |
| parent | df9366131a452296d040a7a496d93108f1fc240c (diff) | |
ASoC: simple-card: Restore original configuration of DAI format
Revert commit 069d037aea98 ("ASoC: simple-card: Fix configuration of
DAI format"). During further review, it turns out that the actual issue
was caused by an incorrectly formatted device-tree node describing the
soundcard.
The following is incorrect because the simple-audio-card
'bitclock-master' and 'frame-master' properties should not reference the
actual codec phandle ...
	sound {
		compatible = "simple-audio-card";
		...
	=>	simple-audio-card,bitclock-master = <&codec>;
	=>	simple-audio-card,frame-master = <&codec>;
		...
		simple-audio-card,cpu {
			sound-dai = <&xxx>;
		};
		simple-audio-card,codec {
	=>		sound-dai = <&codec>;
		};
	};
Rather, these properties should reference the phandle to the
'simple-audio-card,codec' property as shown below ...
	sound {
		compatible = "simple-audio-card";
		...
	=>	simple-audio-card,bitclock-master = <&codec>;
	=>	simple-audio-card,frame-master = <&codec>;
		...
		simple-audio-card,cpu {
			sound-dai = <&xxx>;
		};
	=>	codec: simple-audio-card,codec { /* simple-card wants here */
			sound-dai = <&xxx>;	 /* not here */
		};
	};
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'lib/mpi/mpi-internal.h')
0 files changed, 0 insertions, 0 deletions
