diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2019-07-18 14:56:17 +0200 | 
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2019-07-25 15:39:24 +0200 | 
| commit | 99143f82a255e7f054bead8443462fae76dd829e (patch) | |
| tree | fb581b5301b554d40903c234e22ffab3b21b774b /lib/mpi/mpi-internal.h | |
| parent | e1b98fa316648420d0434d9ff5b92ad6609ba6c3 (diff) | |
lcoking/rwsem: Add missing ACQUIRE to read_slowpath sleep loop
While reviewing another read_slowpath patch, both Will and I noticed
another missing ACQUIRE, namely:
  X = 0;
  CPU0			CPU1
  rwsem_down_read()
    for (;;) {
      set_current_state(TASK_UNINTERRUPTIBLE);
                        X = 1;
                        rwsem_up_write();
                          rwsem_mark_wake()
                            atomic_long_add(adjustment, &sem->count);
                            smp_store_release(&waiter->task, NULL);
      if (!waiter.task)
        break;
      ...
    }
  r = X;
Allows 'r == 0'.
Reported-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reported-by: Will Deacon <will@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Will Deacon <will@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'lib/mpi/mpi-internal.h')
0 files changed, 0 insertions, 0 deletions
