diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2025-01-13 08:23:28 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2025-01-13 08:23:28 -0800 |
| commit | ecdc475e0707c98c2a89da8d0024b3ea2924ef9b (patch) | |
| tree | 04496bde613c09d35f9c0370ea3e39235300c450 /lib/vsprintf.c | |
| parent | fa47906ff358a5865b7be2356a5a1d1e58dd17d8 (diff) | |
vsnprintf: fix the number base for non-numeric formats
Commit 8d4826cc8a8a ("vsnprintf: collapse the number format state into
one single state") changed the format specification decoding to be a bit
more straightforward but in the process ended up also resetting the
number base to zero for formats that aren't clearly numerical.
Now, the number base obviously doesn't matter for something like '%s',
so this wasn't all that obvious. But some of our specialized pointer
extension formatting (ie, things like "print out IPv6 address") did up
depending on the default base-10 setting, and when they then tried to
print out numbers in "base zero", things didn't work out so well.
Most pointer formatting (including things like the default raw hex value
conversion) didn't have this issue, because they used helpers that
explicitly set the base.
Reported-and-tested-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202501131352.e226f995-lkp@intel.com
Fixes: 8d4826cc8a8a ("vsnprintf: collapse the number format state into one single state")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/vsprintf.c')
| -rw-r--r-- | lib/vsprintf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 4432b69a78be..56fe96319292 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -2682,7 +2682,8 @@ qualifier: p = lookup_state + *fmt.str; } if (p->state) { - spec->base = p->base; + if (p->base) + spec->base = p->base; spec->flags |= p->flags_or_double_size; fmt.state = p->state; fmt.str++; |