diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2025-09-12 09:17:03 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-15 18:13:49 -0700 |
| commit | f3b52167a0cb23b27414452fbc1278da2ee884fc (patch) | |
| tree | a6eaf9ed8674880e345f9262f79b2abd6d21c628 /net/core/page_pool.c | |
| parent | 3a0ac202534bcd397e6fd744b6d1038d372c5b5e (diff) | |
page_pool: always add GFP_NOWARN for ATOMIC allocations
Driver authors often forget to add GFP_NOWARN for page allocation
from the datapath. This is annoying to users as OOMs are a fact
of life, and we pretty much expect network Rx to hit page allocation
failures during OOM. Make page pool add GFP_NOWARN for ATOMIC allocations
by default.
Reviewed-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250912161703.361272-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/core/page_pool.c')
| -rw-r--r-- | net/core/page_pool.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/core/page_pool.c b/net/core/page_pool.c index ba70569bd4b0..36a98f2bcac3 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -555,6 +555,12 @@ static noinline netmem_ref __page_pool_alloc_netmems_slow(struct page_pool *pool netmem_ref netmem; int i, nr_pages; + /* Unconditionally set NOWARN if allocating from NAPI. + * Drivers forget to set it, and OOM reports on packet Rx are useless. + */ + if ((gfp & GFP_ATOMIC) == GFP_ATOMIC) + gfp |= __GFP_NOWARN; + /* Don't support bulk alloc for high-order pages */ if (unlikely(pp_order)) return page_to_netmem(__page_pool_alloc_page_order(pool, gfp)); |