diff options
author | Simon Horman <horms@kernel.org> | 2025-06-13 17:46:20 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-06-16 14:12:08 -0700 |
commit | 1224b218a4b9203656ecc932152f4c81a97b4fcc (patch) | |
tree | 947d22998a3504965e0dfc62f8b91f4986f12229 /net/lapb/lapb_timer.c | |
parent | 5466491c9e3309ed5c7adbb8fad6e93fcc9a8fe9 (diff) |
pldmfw: Select CRC32 when PLDMFW is selected
pldmfw calls crc32 code and depends on it being enabled, else
there is a link error as follows. So PLDMFW should select CRC32.
lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'
This problem was introduced by commit b8265621f488 ("Add pldmfw library
for PLDM firmware update").
It manifests as of commit d69ea414c9b4 ("ice: implement device flash
update via devlink").
And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
unnecessary prompt for CONFIG_CRC32 and drop 'default y'").
Found by chance while exercising builds based on tinyconfig.
Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250613-pldmfw-crc32-v1-1-f3fad109eee6@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions