diff options
author | Petr Pavlu <petr.pavlu@suse.com> | 2025-06-18 14:26:26 +0200 |
---|---|---|
committer | Daniel Gomez <da.gomez@samsung.com> | 2025-07-08 20:52:29 +0200 |
commit | ca3881f6fd8e9b6eb2d51e8718d07d3b8029d886 (patch) | |
tree | a65408f73d82a8ecac4d7fe09c67f72fe57176e0 /net/lapb/lapb_timer.c | |
parent | d7b8f8e20813f0179d8ef519541a3527e7661d3a (diff) |
module: Fix memory deallocation on error path in move_module()
The function move_module() uses the variable t to track how many memory
types it has allocated and consequently how many should be freed if an
error occurs.
The variable is initially set to 0 and is updated when a call to
module_memory_alloc() fails. However, move_module() can fail for other
reasons as well, in which case t remains set to 0 and no memory is freed.
Fix the problem by initializing t to MOD_MEM_NUM_TYPES. Additionally, make
the deallocation loop more robust by not relying on the mod_mem_type_t enum
having a signed integer as its underlying type.
Fixes: c7ee8aebf6c0 ("module: add stop-grap sanity check on module memcpy()")
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Daniel Gomez <da.gomez@samsung.com>
Link: https://lore.kernel.org/r/20250618122730.51324-2-petr.pavlu@suse.com
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
Message-ID: <20250618122730.51324-2-petr.pavlu@suse.com>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions