summaryrefslogtreecommitdiff
path: root/net/lapb
diff options
context:
space:
mode:
authorClément Péron <peron.clem@gmail.com>2020-10-30 15:46:35 +0100
committerMark Brown <broonie@kernel.org>2020-10-30 17:58:51 +0000
commitc779e2de0ac6156bea63e759481ee383587336cc (patch)
tree5a4954756603f2d2bcf96134f8bf75e37c029207 /net/lapb
parent93c0210671d8f3ec2262da703fab93a1497158a8 (diff)
ASoC: sun4i-i2s: Change set_chan_cfg() params
As slots and slot_width can be set manually using set_tdm(). These values are then kept in sun4i_i2s struct. So we need to check if these values are set or not. This is not done actually and will trigger a bug. For example, if we set to the simple soundcard in the device-tree dai-tdm-slot-width = <32> and then start a stream using S16_LE, currently we would calculate BCLK for 32-bit slots, but program lrck_period for 16-bit slots, making the sample rate double what we expected. To fix this, we need to check if these values are set or not but as this logic is already done by the caller. Avoid duplicating this logic and just pass the required values as params to set_chan_cfg(). Suggested-by: Samuel Holland <samuel@sholland.org> Acked-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Clément Péron <peron.clem@gmail.com> Link: https://lore.kernel.org/r/20201030144648.397824-3-peron.clem@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'net/lapb')
0 files changed, 0 insertions, 0 deletions