diff options
author | Takashi Iwai <tiwai@suse.de> | 2025-03-21 18:26:52 +0100 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2025-03-21 18:28:28 +0100 |
commit | 3424c8f53bc63c87712a7fc22dc13d0cc85fb0d6 (patch) | |
tree | 0ab7e2e7f6d6d15ab38cbb66125adb10e24e3806 /net/switchdev | |
parent | e8e472d0c5a410227bbde2bba6eb0f428eaf761c (diff) |
ALSA: timer: Don't take register_mutex with copy_from/to_user()
The infamous mmap_lock taken in copy_from/to_user() can be often
problematic when it's called inside another mutex, as they might lead
to deadlocks.
In the case of ALSA timer code, the bad pattern is with
guard(mutex)(®ister_mutex) that covers copy_from/to_user() -- which
was mistakenly introduced at converting to guard(), and it had been
carefully worked around in the past.
This patch fixes those pieces simply by moving copy_from/to_user() out
of the register mutex lock again.
Fixes: 3923de04c817 ("ALSA: pcm: oss: Use guard() for setup")
Reported-by: syzbot+2b96f44164236dda0f3b@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/67dd86c8.050a0220.25ae54.0059.GAE@google.com
Link: https://patch.msgid.link/20250321172653.14310-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'net/switchdev')
0 files changed, 0 insertions, 0 deletions