diff options
author | Josh Poimboeuf <jpoimboe@kernel.org> | 2025-03-24 14:56:10 -0700 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2025-03-25 23:00:29 +0100 |
commit | 29c578c848402a34e8c8e115bf66cb6008b77062 (patch) | |
tree | 177774aef053b944c91b791c455bdaa74c4483d0 /rust/helpers/workqueue.c | |
parent | 060aed9c0093b341480770457093449771cf1496 (diff) |
objtool, regulator: rk808: Remove potential undefined behavior in rk806_set_mode_dcdc()
If 'ctr_bit' is negative, the shift counts become negative, causing a
shift of bounds and undefined behavior.
Presumably that's not possible in normal operation, but the code
generation isn't optimal. And undefined behavior should be avoided
regardless.
Improve code generation and remove the undefined behavior by converting
the signed variables to unsigned.
Fixes the following warning with an UBSAN kernel:
vmlinux.o: warning: objtool: rk806_set_mode_dcdc() falls through to next function rk806_get_mode_dcdc()
vmlinux.o: warning: objtool: .text.rk806_set_mode_dcdc: unexpected end of section
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/2023abcddf3f524ba478d64339996f25dc4097d2.1742852847.git.jpoimboe@kernel.org
Closes: https://lore.kernel.org/oe-kbuild-all/202503182350.52KeHGD4-lkp@intel.com/
Diffstat (limited to 'rust/helpers/workqueue.c')
0 files changed, 0 insertions, 0 deletions