diff options
author | Robin Murphy <robin.murphy@arm.com> | 2025-04-25 14:39:28 +0100 |
---|---|---|
committer | Christophe Leroy <christophe.leroy@csgroup.eu> | 2025-05-13 01:38:55 +0200 |
commit | 152f33ee30ee6a7f4c15bedd7529dc5945315547 (patch) | |
tree | 8088db3d2aa80acaffd9acbfbdaa9586a5c2d7b4 /scripts/lib/kdoc/kdoc_output.py | |
parent | 23d060136841c58c2f9ee8c08ad945d1879ead4b (diff) |
bus: fsl_mc: Fix driver_managed_dma check
Since it's not currently safe to take device_lock() in the IOMMU probe
path, that can race against really_probe() setting dev->driver before
attempting to bind. The race itself isn't so bad, since we're only
concerned with dereferencing dev->driver itself anyway, but sadly my
attempt to implement the check with minimal churn leads to a kind of
TOCTOU issue, where dev->driver becomes valid after to_fsl_mc_driver(NULL)
is already computed, and thus the check fails to work as intended.
Will and I both hit this with the platform bus, but the pattern here is
the same, so fix it for correctness too.
Reported-by: Will McVicker <willmcvicker@google.com>
Fixes: bcb81ac6ae3c ("iommu: Get DT/ACPI parsing into the proper probe path")
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Will McVicker <willmcvicker@google.com>
Link: https://lore.kernel.org/r/20250425133929.646493-3-robin.murphy@arm.com
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_output.py')
0 files changed, 0 insertions, 0 deletions