summaryrefslogtreecommitdiff
path: root/scripts/lib
diff options
context:
space:
mode:
authorManuel Fombuena <fombuena@outlook.com>2025-02-26 17:06:40 +0000
committerLee Jones <lee@kernel.org>2025-03-13 15:28:26 +0000
commita17d9e736ddd78323e77d3066c1e86371a99023c (patch)
treeda9777f408c7401509db693d17688977bfb619c7 /scripts/lib
parent6d91124e7edc109f114b1afe6d00d85d0d0ac174 (diff)
leds: leds-st1202: Initialize hardware before DT node child operations
Arguably, there are more chances of errors occurring during the initialization of the hardware, so this should complete successfully before the devicetree node's children are initialized. st1202_dt_init() fills the led_classdev struct. st1202_setup() initializes the hardware. Specifically, resets the chip, enables its phase-shift delay feature, enables the device and disables all the LEDs channels. All that writing to registers, with no input from st1202_dt_init(). Real-world testing corroborates that calling st1202_setup() before st1202_dt_init() doesn't cause any issue during initialization. Switch the order of st1202_dt_init() and st1202_setup() to ensure the hardware is correctly initialized before the led_classdev struct is filled. Signed-off-by: Manuel Fombuena <fombuena@outlook.com> Link: https://lore.kernel.org/r/CWLP123MB54731877A8DC54EDD33F0229C5C22@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM Signed-off-by: Lee Jones <lee@kernel.org>
Diffstat (limited to 'scripts/lib')
0 files changed, 0 insertions, 0 deletions