diff options
| author | Mickaël Salaün <mic@digikod.net> | 2025-03-31 12:47:07 +0200 |
|---|---|---|
| committer | Mickaël Salaün <mic@digikod.net> | 2025-04-08 19:18:20 +0200 |
| commit | fe81536af3978f26a1383e4da7f135b973eb4209 (patch) | |
| tree | a830d964f93f01d67a87293f64d71e18912f0be4 /security | |
| parent | 0af2f6be1b4281385b618cb86ad946eded089ac8 (diff) | |
landlock: Remove incorrect warning
landlock_put_hierarchy() can be called when an error occurs in
landlock_merge_ruleset() due to insufficient memory. In this case, the
domain's audit details might not have been allocated yet, which would
cause landlock_free_hierarchy_details() to print a warning (but still
safely handle this case).
We could keep the WARN_ON_ONCE(!hierarchy) but it's not worth it for
this kind of function, so let's remove it entirely.
Cc: Paul Moore <paul@paul-moore.com>
Reported-by: syzbot+8bca99e91de7e060e4ea@syzkaller.appspotmail.com
Link: https://lore.kernel.org/r/20250331104709.897062-1-mic@digikod.net
Reviewed-by: Günther Noack <gnoack@google.com>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Diffstat (limited to 'security')
| -rw-r--r-- | security/landlock/domain.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/landlock/domain.h b/security/landlock/domain.h index ed0d348e214c..7fb70b25f85a 100644 --- a/security/landlock/domain.h +++ b/security/landlock/domain.h @@ -130,7 +130,7 @@ int landlock_init_hierarchy_log(struct landlock_hierarchy *const hierarchy); static inline void landlock_free_hierarchy_details(struct landlock_hierarchy *const hierarchy) { - if (WARN_ON_ONCE(!hierarchy || !hierarchy->details)) + if (!hierarchy || !hierarchy->details) return; put_pid(hierarchy->details->pid); |