summaryrefslogtreecommitdiff
path: root/tools/lib/traceevent/parse-utils.c
diff options
context:
space:
mode:
authorMa Ke <make24@iscas.ac.cn>2025-03-03 15:27:39 +0800
committerVinod Koul <vkoul@kernel.org>2025-05-14 12:28:43 +0100
commitb2ea5f49580c0762d17d80d8083cb89bc3acf74f (patch)
treeacbfcb2ce7f0adc7bc9711ca9fb3dc2dfe65081d /tools/lib/traceevent/parse-utils.c
parent86e70849f4b2b4597ac9f7c7931f2a363774be25 (diff)
phy: Fix error handling in tegra_xusb_port_init
If device_add() fails, do not use device_unregister() for error handling. device_unregister() consists two functions: device_del() and put_device(). device_unregister() should only be called after device_add() succeeded because device_del() undoes what device_add() does if successful. Change device_unregister() to put_device() call before returning from the function. As comment of device_add() says, 'if device_add() succeeds, you should call device_del() when you want to get rid of it. If device_add() has not succeeded, use only put_device() to drop the reference count'. Found by code review. Cc: stable@vger.kernel.org Fixes: 53d2a715c240 ("phy: Add Tegra XUSB pad controller support") Signed-off-by: Ma Ke <make24@iscas.ac.cn> Acked-by: Thierry Reding <treding@nvidia.com> Link: https://lore.kernel.org/r/20250303072739.3874987-1-make24@iscas.ac.cn Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'tools/lib/traceevent/parse-utils.c')
0 files changed, 0 insertions, 0 deletions