diff options
author | Xiaomeng Tong <xiam0nd.tong@gmail.com> | 2022-04-08 16:47:15 +0800 |
---|---|---|
committer | Song Liu <song@kernel.org> | 2022-04-25 14:00:35 -0700 |
commit | 64c54d9244a4efe9bc6e9c98e13c4bbb8bb39083 (patch) | |
tree | e7460c9fd8dd10b4556fe3728a7490eeba0398e5 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | fc8738343eefc4ea8afb6122826dea48eacde514 (diff) |
md: fix an incorrect NULL check in md_reload_sb
The bug is here:
if (!rdev || rdev->desc_nr != nr) {
The list iterator value 'rdev' will *always* be set and non-NULL
by rdev_for_each_rcu(), so it is incorrect to assume that the
iterator value will be NULL if the list is empty or no element
found (In fact, it will be a bogus pointer to an invalid struct
object containing the HEAD). Otherwise it will bypass the check
and lead to invalid memory access passing the check.
To fix the bug, use a new variable 'iter' as the list iterator,
while using the original variable 'pdev' as a dedicated pointer to
point to the found element.
Cc: stable@vger.kernel.org
Fixes: 70bcecdb1534 ("md-cluster: Improve md_reload_sb to be less error prone")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Signed-off-by: Song Liu <song@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions