diff options
author | Justin Stitt <justinstitt@google.com> | 2023-09-25 07:06:03 +0000 |
---|---|---|
committer | Mike Snitzer <snitzer@kernel.org> | 2023-10-23 13:02:48 -0400 |
commit | 18ac52332959aaf4bee54ee1b760959beeb13ae2 (patch) | |
tree | 5ecaa2121779b1a158d77af96ca40229bd1b78a9 /tools/perf/scripts/python/export-to-sqlite.py | |
parent | 0ffb645ea821fbad4215b6a5681b823639c24660 (diff) |
dm log userspace: replace deprecated strncpy with strscpy
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
`lc` is already zero-allocated:
| lc = kzalloc(sizeof(*lc), GFP_KERNEL);
... as such, any future NUL-padding is superfluous.
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.
Let's also go with the more idiomatic `dest, src, sizeof(dest)` pattern
for destination buffers that the compiler can calculate the size for.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions