diff options
author | Kuan-Wei Chiu <visitorckw@gmail.com> | 2025-01-16 19:08:42 +0800 |
---|---|---|
committer | Namhyung Kim <namhyung@kernel.org> | 2025-01-18 10:14:36 -0800 |
commit | 62892e77b8a64b9dc0e1da75980aa145347b6820 (patch) | |
tree | a21d0dcdb4b7a136b2c96ced1be4f751f501c658 /tools/perf/scripts/python/export-to-sqlite.py | |
parent | 035f0c279bcfc07314240de273d90f4061aef04d (diff) |
perf bench: Fix undefined behavior in cmpworker()
The comparison function cmpworker() violates the C standard's
requirements for qsort() comparison functions, which mandate symmetry
and transitivity:
Symmetry: If x < y, then y > x.
Transitivity: If x < y and y < z, then x < z.
In its current implementation, cmpworker() incorrectly returns 0 when
w1->tid < w2->tid, which breaks both symmetry and transitivity. This
violation causes undefined behavior, potentially leading to issues such
as memory corruption in glibc [1].
Fix the issue by returning -1 when w1->tid < w2->tid, ensuring
compliance with the C standard and preventing undefined behavior.
Link: https://www.qualys.com/2024/01/30/qsort.txt [1]
Fixes: 121dd9ea0116 ("perf bench: Add epoll parallel epoll_wait benchmark")
Cc: stable@vger.kernel.org
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250116110842.4087530-1-visitorckw@gmail.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions