diff options
author | Li Huafei <lihuafei1@huawei.com> | 2024-10-19 23:41:56 +0800 |
---|---|---|
committer | Namhyung Kim <namhyung@kernel.org> | 2024-10-23 15:36:06 -0700 |
commit | 908d50e50ef91713ae94bc8988db87def6b6fec3 (patch) | |
tree | d4e9a7a3f6498750cf739d735744b0869c037cd2 /tools/perf/scripts/python/export-to-sqlite.py | |
parent | b4e0e9a1e30059f4523c9b6a1f8045ad89b5db8a (diff) |
perf disasm: Use disasm_line__free() to properly free disasm_line
symbol__disassemble_capstone_powerpc() goto the 'err' label when it
failed in the loop that created disasm_line, and then used free()
directly to free disasm_line. Since the structure disasm_line contains
members that allocate memory dynamically, this can result in a memory
leak. In fact, we can simply break the loop when it fails in the middle
of the loop, and disasm_line__free() will then be called to properly
free the created line. Other error paths do not need to consider freeing
disasm_line.
Fixes: c5d60de1813a ("perf annotate: Add support to use libcapstone in powerpc")
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: sesse@google.com
Cc: kjain@linux.ibm.com
Link: https://lore.kernel.org/r/20241019154157.282038-2-lihuafei1@huawei.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions