diff options
author | Jakub Kicinski <kuba@kernel.org> | 2023-06-22 19:41:13 -0700 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-06-22 19:41:13 -0700 |
commit | 018c00dd4e88d78b0e97d4bcc413dd727497128f (patch) | |
tree | ca78b996831ab928aa7cadc4e5516837bf8fc1e5 /tools/perf/scripts/python/stackcollapse.py | |
parent | 84ef94d9421d39b9148f2f4fd4cca2888deb6103 (diff) | |
parent | f40df95d375dc9c96da541a2c4ac0ce1e630309d (diff) |
Merge branch 'add-and-use-helper-for-pcs-negotiation-modes'
Russell King says:
====================
Add and use helper for PCS negotiation modes
Earlier this month, I proposed a helper for deciding whether a PCS
should use inband negotiation modes or not. There was some discussion
around this topic, and I believe there was no disagreement about
providing the helper.
The initial discussion can be found at:
https://lore.kernel.org/r/ZGIkGmyL8yL1q1zp@shell.armlinux.org.uk
Subsequently, I posted a RFC series back in May:
https://lore.kernel.org/r/ZGzhvePzPjJ0v2En@shell.armlinux.org.uk
that added a helper, phylink_pcs_neg_mode() which PCS drivers could use
to parse the state, and updated a bunch of drivers to use it. I got
a couple of bits of feedback to it, including some ACKs.
However, I've decided to take this slightly further and change the
"mode" parameter to both the pcs_config() and pcs_link_up() methods
when a PCS driver opts in to this (by setting "neg_mode" in the
phylink_pcs structure.) If this is not set, we default to the old
behaviour. That said, this series converts all the PCS implementations
I can find currently in net-next.
Doing this has the added benefit that the negotiation mode parameter
is also available to the pcs_link_up() function, which can now know
whether inband negotiation was in fact enabled or not at pcs_config()
time.
It has been posted as RFC at:
https://lore.kernel.org/r/ZIh/CLQ3z89g0Ua0@shell.armlinux.org.uk
and received one reply, thanks Elad, which is a similar amount of
interest to previous postings. Let's post it as non-RFC and see
whether we get more reaction.
====================
Link: https://lore.kernel.org/r/ZIxQIBfO9dH5xFlg@shell.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/stackcollapse.py')
0 files changed, 0 insertions, 0 deletions