diff options
author | Baokun Li <libaokun1@huawei.com> | 2024-05-22 19:43:07 +0800 |
---|---|---|
committer | Christian Brauner <brauner@kernel.org> | 2024-05-29 13:03:31 +0200 |
commit | 85e833cd7243bda7285492b0653c3abb1e2e757b (patch) | |
tree | 1bd417768f7b60007a1bac6deb5c28d8cad995be /tools/perf/scripts/python/task-analyzer.py | |
parent | 4f8703fb3482f92edcfd31661857b16fec89c2c0 (diff) |
cachefiles: flush all requests after setting CACHEFILES_DEAD
In ondemand mode, when the daemon is processing an open request, if the
kernel flags the cache as CACHEFILES_DEAD, the cachefiles_daemon_write()
will always return -EIO, so the daemon can't pass the copen to the kernel.
Then the kernel process that is waiting for the copen triggers a hung_task.
Since the DEAD state is irreversible, it can only be exited by closing
/dev/cachefiles. Therefore, after calling cachefiles_io_error() to mark
the cache as CACHEFILES_DEAD, if in ondemand mode, flush all requests to
avoid the above hungtask. We may still be able to read some of the cached
data before closing the fd of /dev/cachefiles.
Note that this relies on the patch that adds reference counting to the req,
otherwise it may UAF.
Fixes: c8383054506c ("cachefiles: notify the user daemon when looking up cookie")
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Link: https://lore.kernel.org/r/20240522114308.2402121-12-libaokun@huaweicloud.com
Acked-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions