diff options
author | Yu Kuai <yukuai3@huawei.com> | 2023-05-27 09:06:43 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2023-06-26 09:53:36 -0600 |
commit | eebc21d12f56c1e09a163abf91e351fa2a55a938 (patch) | |
tree | 31b8644fe6536bd0d886911844505c91abf68bb4 /tools/perf/scripts/python/task-analyzer.py | |
parent | 06257fda83ebfd1c33fb992e41dba7be4e1184d4 (diff) |
blk-iocost: move wbt_enable/disable_default() out of spinlock
There are following smatch warning:
block/blk-wbt.c:843 wbt_init() warn: sleeping in atomic context
ioc_qos_write() <- disables preempt
-> wbt_enable_default()
-> wbt_init()
wbt_init() will be called from wbt_enable_default() if wbt is not
initialized, currently this is only possible in blk_register_queue(), hence
wbt_init() will never be called from iocost and this warning is false
positive.
However, we might support rq_qos destruction dynamically in the future,
and it's better to prevent that, hence move wbt_enable_default() outside
'ioc->lock'. This is safe because queue is still freezed.
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/lkml/Y+Ja5SRs886CEz7a@kadam/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230527010644.647900-5-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions