diff options
author | Jethro Donaldson <devel@jro.nz> | 2025-05-15 01:23:23 +1200 |
---|---|---|
committer | Steve French <stfrench@microsoft.com> | 2025-05-14 19:26:15 -0500 |
commit | 1fe4a44b7fa3955bcb7b4067c07b778fe90d8ee7 (patch) | |
tree | e22246228790c15a0ea24dbdbb7eccfc704318f1 /tools/testing/radix-tree/linux/kernel.h | |
parent | 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 (diff) |
smb: client: fix memory leak during error handling for POSIX mkdir
The response buffer for the CREATE request handled by smb311_posix_mkdir()
is leaked on the error path (goto err_free_rsp_buf) because the structure
pointer *rsp passed to free_rsp_buf() is not assigned until *after* the
error condition is checked.
As *rsp is initialised to NULL, free_rsp_buf() becomes a no-op and the leak
is instead reported by __kmem_cache_shutdown() upon subsequent rmmod of
cifs.ko if (and only if) the error path has been hit.
Pass rsp_iov.iov_base to free_rsp_buf() instead, similar to the code in
other functions in smb2pdu.c for which *rsp is assigned late.
Cc: stable@vger.kernel.org
Signed-off-by: Jethro Donaldson <devel@jro.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'tools/testing/radix-tree/linux/kernel.h')
0 files changed, 0 insertions, 0 deletions